Conversation
Contributor
Contributor
|
🚀 Deployed on https://67868c4d430dfc85b0e00916--pglite.netlify.app |
samwillis
approved these changes
Jan 14, 2025
Collaborator
samwillis
left a comment
There was a problem hiding this comment.
Nice, thanks! Looks like it solved something with affectedRows in the tests too?
We should add another changeset
From the root of the repo run pnpm changeset and follow the instructions. Everything is a patch change at the moment.
Collaborator
Author
In some cases, like
I hope that no other code was relying on the fact that it was not present. Also, note this case: No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a bit the return of the
parseResults()function in certain cases - see the updated basic testtestEsmAndCjs.