Skip to content

Message parsing optimization #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdrz merged 3 commits into from
Jan 14, 2025
+14 −20
Merged

Message parsing optimization #495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74ad28e
do not run twice through the messages when parsing
Jan 14, 2025
a94e9b9
return affectedRows as 0 when the resultSets is empty
Jan 14, 2025
0b38e49
changeset
Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions packages/pglite/src/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,7 @@ export function parseResults(
let affectedRows = 0
const parsers = { ...defaultParsers, ...options?.parsers }

const processMessageTypes = new Set([
'rowDescription',
'dataRow',
'commandComplete',
])

const filteredMessages = messages.filter((msg) =>
processMessageTypes.has(msg.name),
)

filteredMessages.forEach((message, index) => {
messages.forEach((message) => {
switch (message.name) {
case 'rowDescription': {
const msg = message as RowDescriptionMessage
Expand Down Expand Up @@ -73,15 +63,11 @@ export function parseResults(
const msg = message as CommandCompleteMessage
affectedRows += retrieveRowCount(msg)

if (index === filteredMessages.length - 1) {
resultSets.push({
...currentResultSet,
affectedRows,
...(blob ? { blob } : {}),
})
} else {
resultSets.push(currentResultSet)
}
resultSets.push({
...currentResultSet,
affectedRows,
...(blob ? { blob } : {}),
})

currentResultSet = { rows: [], fields: [] }
break
Expand Down
2 changes: 2 additions & 0 deletions packages/pglite/tests/basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ await testEsmAndCjs(async (importType) => {

expect(multiStatementResult).toEqual([
{
affectedRows: 1,
rows: [],
fields: [],
},
{
affectedRows: 2,
rows: [],
fields: [],
},
Expand Down