Skip to content

Conversation

@3nprob
Copy link

@3nprob 3nprob commented Aug 9, 2022

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

As per #396 (comment)

Type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 9, 2022
@3nprob
Copy link
Author

3nprob commented Aug 9, 2022

Signed-off-by: 3nprob <[email protected]>

@github-actions github-actions bot added the T-Task Tasks for the team like planning label Aug 9, 2022
@3nprob 3nprob marked this pull request as ready for review August 9, 2022 01:37
@3nprob 3nprob requested a review from a team as a code owner August 9, 2022 01:37
@3nprob
Copy link
Author

3nprob commented Aug 9, 2022

This PR is redundant if matrix-org/matrix-js-sdk#2572 is merged.

@t3chguy
Copy link
Member

t3chguy commented Aug 9, 2022

Rules should be added to the matrix-org eslint plugin for consistency, thanks

@t3chguy t3chguy closed this Aug 9, 2022
@3nprob 3nprob deleted the lint-wrap-boolean-operators branch August 9, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants