Skip to content

Add a banner to ask the user to disable battery optimization when Event cannot be resolved from Push #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmarty merged 10 commits into from
Jun 16, 2025

Use defined const instead of magic numbers.

9956ed6
Select commit
Loading
Failed to load commit list.
Merged

Add a banner to ask the user to disable battery optimization when Event cannot be resolved from Push #4845

Use defined const instead of magic numbers.
9956ed6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 9, 2025 in 1s

80.28% (-0.02%) compared to 11c2467

View this Pull Request on Codecov

80.28% (-0.02%) compared to 11c2467

Details

Codecov Report

Attention: Patch coverage is 63.41463% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.28%. Comparing base (11c2467) to head (9956ed6).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...libraries/push/impl/battery/BatteryOptimization.kt 0.00% 12 Missing ⚠️
.../libraries/push/impl/store/DefaultPushDataStore.kt 0.00% 9 Missing ⚠️
.../push/impl/push/MutableBatteryOptimizationStore.kt 0.00% 4 Missing ⚠️
.../push/impl/battery/BatteryOptimizationPresenter.kt 86.95% 0 Missing and 3 partials ⚠️
...mlist/impl/components/BatteryOptimizationBanner.kt 90.90% 0 Missing and 1 partial ⚠️
...ement/android/libraries/push/impl/di/PushModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4845      +/-   ##
===========================================
- Coverage    80.29%   80.28%   -0.02%     
===========================================
  Files         2140     2146       +6     
  Lines        56902    56982      +80     
  Branches      7158     7170      +12     
===========================================
+ Hits         45688    45746      +58     
- Misses        8781     8799      +18     
- Partials      2433     2437       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov