Skip to content

Add a banner to ask the user to disable battery optimization when Event cannot be resolved from Push #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmarty merged 10 commits into from
Jun 16, 2025

Use defined const instead of magic numbers.

9956ed6
Select commit
Loading
Failed to load commit list.
Merged

Add a banner to ask the user to disable battery optimization when Event cannot be resolved from Push #4845

Use defined const instead of magic numbers.
9956ed6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jun 9, 2025 in 0s

63.41% of diff hit (target 80.29%)

View this Pull Request on Codecov

63.41% of diff hit (target 80.29%)

Annotations

Check warning on line 50 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 63 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt#L61-L63 

Added lines #L61 - L63 were not covered by tests

Check warning on line 66 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt#L65-L66 

Added lines #L65 - L66 were not covered by tests

Check warning on line 69 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimization.kt#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 28 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/di/PushModule.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/di/PushModule.kt#L28 

Added line #L28 was not covered by tests

Check warning on line 22 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt#L21-L22 

Added lines #L21 - L22 were not covered by tests

Check warning on line 25 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt#L25 

Added line #L25 was not covered by tests

Check warning on line 29 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/MutableBatteryOptimizationStore.kt#L29 

Added line #L29 was not covered by tests

Check warning on line 53 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt#L53 

Added line #L53 was not covered by tests

Check warning on line 60 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt#L59-L60 

Added lines #L59 - L60 were not covered by tests

Check warning on line 72 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt#L72 

Added line #L72 was not covered by tests

Check warning on line 78 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/store/DefaultPushDataStore.kt#L76-L78 

Added lines #L76 - L78 were not covered by tests
View more details on Codecov