-
Notifications
You must be signed in to change notification settings - Fork 296
Add emoji search to the reaction emoji picker #5255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5255 +/- ##
===========================================
+ Coverage 79.61% 79.65% +0.03%
===========================================
Files 2254 2258 +4
Lines 62374 62491 +117
Branches 7827 7830 +3
===========================================
+ Hits 49662 49776 +114
- Misses 9848 9849 +1
- Partials 2864 2866 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Out of curiosity, is there some context for this? The keyboard and bottom sheet not opening smoothly still drives me nuts every day, so I'd be curious to see how well this works with the new library version |
Works great! Thanks for integrating this. |
It's on the latest Material 3 Compose |
Fixing the tests required addressing some underlying issues in `SearchBar`
4efa408
to
60e266b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK, thanks!
|
Content
Add search functionality to the emoji reaction selector.
Thanks @ChelseaDH for his initial work on #2892, which served as inspiration for this one.
Note the bottom sheet being collapsed when the keyboard opens remains an issue, but since the only alternative is implementing our own bottom sheet, there's not much we can do about it.Actually this issue was fixed on the latest Material 3 Compose library, which we can't include yet.Motivation and context
Manually searching for an emoji is slow and inefficient.
Screenshots / GIFs
In the PR.
Tests
In a room, long press to display the timeline item menu and tap on the 'emoji +' button to open the whole list of emoji reactions.
You can use it to search for different emojis based on its tags and shortcodes - I could also have added the label, but it's usually a combination of the tags.
Tested devices
Checklist