Skip to content

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Sep 2, 2025

Content

Add search functionality to the emoji reaction selector.

Thanks @ChelseaDH for his initial work on #2892, which served as inspiration for this one.

Note the bottom sheet being collapsed when the keyboard opens remains an issue, but since the only alternative is implementing our own bottom sheet, there's not much we can do about it. Actually this issue was fixed on the latest Material 3 Compose library, which we can't include yet.

Motivation and context

Manually searching for an emoji is slow and inefficient.

Screenshots / GIFs

In the PR.

Tests

In a room, long press to display the timeline item menu and tap on the 'emoji +' button to open the whole list of emoji reactions.

You can use it to search for different emojis based on its tags and shortcodes - I could also have added the label, but it's usually a combination of the tags.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Feature For a new feature label Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NeY4Sb

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 96.34146% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.65%. Comparing base (a2dd455) to head (60e266b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ne/components/customreaction/picker/EmojiPicker.kt 94.87% 1 Missing and 3 partials ⚠️
...ents/customreaction/picker/EmojiPickerPresenter.kt 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5255      +/-   ##
===========================================
+ Coverage    79.61%   79.65%   +0.03%     
===========================================
  Files         2254     2258       +4     
  Lines        62374    62491     +117     
  Branches      7827     7830       +3     
===========================================
+ Hits         49662    49776     +114     
- Misses        9848     9849       +1     
- Partials      2864     2866       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp marked this pull request as ready for review September 2, 2025 10:59
@jmartinesp jmartinesp requested a review from a team as a code owner September 2, 2025 10:59
@jmartinesp jmartinesp requested review from bmarty and removed request for a team September 2, 2025 10:59
@frebib
Copy link
Contributor

frebib commented Sep 2, 2025

Actually this issue was fixed on the latest Material 3 Compose library, which we can't include yet.

Out of curiosity, is there some context for this? The keyboard and bottom sheet not opening smoothly still drives me nuts every day, so I'd be curious to see how well this works with the new library version

@frebib
Copy link
Contributor

frebib commented Sep 2, 2025

Works great! Thanks for integrating this.
Credit for the initial patch goes to @ChelseaDH, not me!

@jmartinesp
Copy link
Member Author

Actually this issue was fixed on the latest Material 3 Compose library, which we can't include yet.

Out of curiosity, is there some context for this? The keyboard and bottom sheet not opening smoothly still drives me nuts every day, so I'd be curious to see how well this works with the new library version

It's on the latest Material 3 Compose 1.4.0-beta version but I think that one pulls the latest Compose versions, which breaks most of our screenshot tests containing dialogs: #5179 (comment)

jmartinesp and others added 3 commits September 5, 2025 18:10
Fixing the tests required addressing some underlying issues in `SearchBar`
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK, thanks!

@bmarty bmarty enabled auto-merge (squash) September 5, 2025 16:45
Copy link

sonarqubecloud bot commented Sep 5, 2025

@bmarty bmarty merged commit bdb9acf into develop Sep 5, 2025
29 checks passed
@bmarty bmarty deleted the feat/emoji-search branch September 5, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants