Multi accounts - experimental first implementation #5285

bmarty · 2025-09-04T16:56:20Z

Content

Add ability to connect to several accounts at the same time. The feature is behind a feature flag.

Warning: the feature must be considered as unstable, and the core team will not have time to fix reported issues right now. In particular, some session verification issue have been observed and not investigated yet.

What is working:

connect to several accounts
switch between accounts, from the setting menu or by swiping vertically on the user avatar at top left.
receive push for any account and let the notification click navigate to the correct account/room/event
if several accounts are connected, display an account select screen for:
- incoming share (sharing content from other apps to EX)
- permalink click from any other application (matrix.to link)
login link when an account is already login in will also let the user login to another account (with the info in the link)
disconnect to any account

Motivation and context

Partially implements #190

Screenshots / GIFs

Tests

Log in to a first account
Enable the feature flag Multi accounts in the developer settings
A new menu in the setting will allow to add another account

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

github-actions · 2025-09-04T17:08:37Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UqrEQF

codecov · 2025-09-05T12:36:45Z

Codecov Report

❌ Patch coverage is 89.21569% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.37%. Comparing base (0b4b63a) to head (e409630).

Files with missing lines	Patch %	Lines
...atrix/impl/auth/RustMatrixAuthenticationService.kt	0.00%	13 Missing ⚠️
...id/features/home/impl/components/RoomListTopBar.kt	77.77%	1 Missing and 7 partials ⚠️
...tures/preferences/impl/root/PreferencesRootView.kt	82.60%	1 Missing and 3 partials ⚠️
...es/login/impl/screens/onboarding/OnBoardingView.kt	95.16%	1 Missing and 2 partials ⚠️
.../libraries/accountselect/impl/AccountSelectView.kt	91.17%	1 Missing and 2 partials ⚠️
...io/element/android/appnav/store/SessionStoreExt.kt	0.00%	1 Missing ⚠️
...o/element/android/features/home/impl/HomeEvents.kt	0.00%	1 Missing ⚠️
...lement/android/features/home/impl/HomePresenter.kt	92.30%	1 Missing ⚠️
.../io/element/android/features/home/impl/HomeView.kt	66.66%	1 Missing ⚠️
...t/android/features/login/impl/login/LoginHelper.kt	50.00%	0 Missing and 1 partial ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5285      +/-   ##
===========================================
- Coverage    80.38%   80.37%   -0.01%     
===========================================
  Files         2275     2282       +7     
  Lines        62860    63212     +352     
  Branches      7863     7904      +41     
===========================================
+ Hits         50527    50809     +282     
- Misses        9431     9481      +50     
- Partials      2902     2922      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Else when 1 of many accounts is removed, the analytics opt in screen is displayed again.

…ogin link.

bmarty · 2025-09-08T14:36:16Z

It seems like viewing internal logs broke with this PR applied, not sure why

It seems to come from #5253 and is also impacting develop. I will fix.

ganfra

Nice work!
Some remarks on first look, I'll also test it tomorrow.

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/HomePresenter.kt

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/HomeState.kt

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/HomePresenter.kt

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/HomeState.kt

...mpl/src/main/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStore.kt

It allows having the cached data (user display name and avatar) when starting the application when no network is available.

tom

Also do not restore the last session as a fallback, it can lead to error in a multi account context, or even when a ghost pusher send a Push.

…ionStore

…ching between accounts.

sonarqubecloud · 2025-09-19T13:57:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bmarty added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Sep 4, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 4, 2025

bmarty force-pushed the feature/bma/_poc/multiAccounts3 branch from 137d98b to cea6001 Compare September 5, 2025 12:06

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 5, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 5, 2025

bmarty changed the title ~~Multi accounts - WIP~~ Multi accounts - Unstable Sep 5, 2025

bmarty changed the title ~~Multi accounts - Unstable~~ Multi accounts - experimental first implementation Sep 5, 2025

bmarty marked this pull request as ready for review September 5, 2025 15:46

bmarty requested a review from a team as a code owner September 5, 2025 15:46

bmarty requested review from ganfra and removed request for a team September 5, 2025 15:46

bmarty added 16 commits September 5, 2025 18:00

Multi account - Do not reset analytics store on sign out.

16a7fb3

Else when 1 of many accounts is removed, the analytics opt in screen is displayed again.

Multi accounts - first implementation.

d487372

Multi accounts - Prevent user from logging twice with the same account

8ebfadd

Multi accounts - ignore automatic GoBack in case of error.

0859fc3

Multi accounts - update first view when adding an account.

f51b392

Rename method storeData to addSession.

8ea5d0e

Multi accounts - handle account switch when coming from a notification

e9987ef

Multi accounts - handle login link when there is already an account.

3355446

Multi accounts - handle click on push history for not current account.

00d06f4

Multi accounts - improve layout and add preview.

9fa25c5

Add accountselect modules

d2130bc

Multi accounts - incoming share with account selection

b545f1e

Multi accounts - check the feature flag before allowing login using l…

77f0aec

…ogin link.

Multi accounts - swipe on account icon

4dc81ed

Cleanup

a2bac35

Multi accounts - fix other implementation of SessionStore

b80ef4b

Fix compilation issue after rebase on develop.

614ea0d

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 5, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 5, 2025

Update screenshots

3a46fec

This comment was marked as off-topic.

Sign in to view

bmarty mentioned this pull request Sep 8, 2025

Restore view log code #5294

Merged

9 tasks

bmarty and others added 2 commits September 11, 2025 17:34

Merge branch 'develop' into feature/bma/_poc/multiAccounts3

866a17d

Fix test

5e85065

ganfra reviewed Sep 16, 2025

View reviewed changes

bmarty and others added 19 commits September 17, 2025 09:42

Avoid calling getLatestSession() twice

2d77a63

Rename matrixUserAndNeighbors to currentUserAndNeighbors

5d0db44

Extract code to its own class.

b334f27

Add comment to clarify the code.

2ec6b2c

Init current user profile with what we now have in the database.

6baf08b

It allows having the cached data (user display name and avatar) when starting the application when no network is available.

Let the RustMatrixClient update the profile in the session database

a84e2ff

Fix test.

e942e90

When logging out from Pin code screen, logout from all the sessions.

823cd97

tom

Make PushData.clientSecret mandatory.

097fc98

Also do not restore the last session as a fallback, it can lead to error in a multi account context, or even when a ghost pusher send a Push.

Change test in RustMatrixAuthenticationServiceTest

7059c23

Do not use MatrixAuthenticationService in RootFlowNode, only use Sess…

f589dd2

…ionStore

Remove MatrixAuthenticationService.getLatestSessionId()

3fd97c1

Merge branch 'develop' into feature/bma/_poc/multiAccounts3

c3e88d6

Fix compilation issue after merging develop

81e7911

Add test on DefaultAccountSelectEntryPoint

b8c441f

Fix compilation issue after merging develop

b3f3f52

Introduce LoggedInAccountSwitcherNode, to improve animation when swit…

9c698ff

…ching between accounts.

Rename Node to follow naming convention.

883b1f3

Fix navigation issue after login.

e409630

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multi accounts - experimental first implementation #5285

Multi accounts - experimental first implementation #5285

bmarty commented Sep 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 5, 2025 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

Uh oh!

bmarty commented Sep 8, 2025

Uh oh!

ganfra left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 19, 2025

Uh oh!

Uh oh!

Multi accounts - experimental first implementation #5285

Are you sure you want to change the base?

Multi accounts - experimental first implementation #5285

Conversation

bmarty commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as off-topic.

Uh oh!

bmarty commented Sep 8, 2025

Uh oh!

ganfra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 19, 2025

Quality Gate passed

Uh oh!

Uh oh!

bmarty commented Sep 4, 2025 •

edited

Loading

github-actions bot commented Sep 4, 2025 •

edited

Loading

codecov bot commented Sep 5, 2025 •

edited

Loading