-
Notifications
You must be signed in to change notification settings - Fork 401
Document "Developer options" and remove outdated instructions #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document "Developer options" and remove outdated instructions #6162
Conversation
|
|
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
It looks like these were just copied across from https://github.com/element-hq/element-android/blob/develop/docs/_developer_onboarding.md and no longer apply.
e36d7f4 to
ef664fc
Compare
| * [Developer options](#developer-options) | ||
| * [Tips](#tips) | ||
| * [Happy coding!](#happy-coding) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: CLA
I'm an Element employee and the commit is already using my Element address ⏩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6162 +/- ##
===========================================
- Coverage 81.37% 81.36% -0.01%
===========================================
Files 2569 2569
Lines 69700 69700
Branches 8963 8963
===========================================
- Hits 56716 56712 -4
- Misses 9650 9655 +5
+ Partials 3334 3333 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Since we're already changing this maybe we should also point out modifying developer options can result in the app not working as expected and it should only be done if the user knows what they're doing or if instructed by someone at Element?
|
Thanks for the review and merge @jmartinesp and @bmarty 🐡 |
Content
element-androidbut no longer applyMotivation and context
Spawning from the new space management UI being demoed in the monthly wrap but being unable to find the feature toggles.
Screenshots / GIFs
N/A, just a docs update
Tests
N/A, just a docs update
Tested devices
Checklist
Changes have been tested on an Android device or Android emulator with API 24N/AUI change has been tested on both light and dark themesN/A