Show correct error screen scanning a QR that is valid but unsupported#5196
Draft
Show correct error screen scanning a QR that is valid but unsupported#5196
Conversation
hughns
commented
Mar 12, 2026
ElementX/Sources/Services/Authentication/AuthenticationService.swift
Outdated
Show resolved
Hide resolved
Uses the new .UnsupportedQrCodeType enum errors code from the SDK in matrix-org/matrix-rust-sdk#6285. Specifically this means that if a QR from a new version of MSC4108 is encountered then it shows it as "wrong QR" rather than "the other device isn't signed in".
hughns
force-pushed
the
hughns/unsupported-qr-code-type
branch
from
1e49865 to
01468d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new .UnsupportedQrCodeType enum errors code from the SDK in matrix-org/matrix-rust-sdk#6285.
Specifically this means that if a QR from a new version of MSC4108 is encountered then it shows it as "wrong QR" rather than "the other device isn't signed in".
Pull Request Checklist
UI changes have been tested with: