Switch to @tanstack/react-query for GraphQL requests #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
083dc42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0e67828f.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-tanstack-q.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/frontend/tanstack-query
branch
6 times, most recently
from
f33ae39 to
b911572
Compare
sandhose
force-pushed
the
quenting/frontend/tanstack-query
branch
from
0b1a6ee to
75b9597
Compare
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to
@tanstack/react-queryfor doing GraphQL requests instead ofurql.One reason is that it has better behaviour in Suspense, and integrates well with
@tanstack/router.We also don't really use any of the urql 'unified cache' feature, but instead will now rely on explicit query invalidation, which is easier to reason about.
I also took a shot at actually starting to test full pages, using
mswto mock GraphQL responses. For now, it's just a snapshot test of the homepage, but it should be easy to replicate in other places.I also started to add full-pages stories in storybook, which should help with previewing pages without setting up MAS, potentially with different languages.