Create missing indexes for all the foreign keys in the database. #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
c861856
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a9ca8be.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-fk-indexes.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Apr 14, 2025
sandhose
added
T-Defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new index for each foreign key in the database.
One trick is that we need those indexes to be created concurrently, which needs to be done outside of a transaction.
To do so, every single statement has to be in its own file, starting with
-- no-transaction.This is a known limitation of sqlx
It also adds two missing indexes: on the emails and on the recovery tickets.
Fixes #4370