Allow applying unicode normalisation to passwords before hashing #4599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/password-unicode-normalisation
branch
from
c634df2 to
40cb052
Compare
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
40cb052
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56b98d69.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-password-unicode-no.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
May 30, 2025
sandhose
added
A-Local-Password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4598
Fixes #4581
This adds a new flag on password schemes to apply NFKC normalization to the password before hashing it. It's recommended to not use this, but required when importing passwords from Synapse.