-
Notifications
You must be signed in to change notification settings - Fork 55
config: Refactor parsing of secrets section #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kai A. Hiller <[email protected]>
Signed-off-by: Kai A. Hiller <[email protected]>
Signed-off-by: Kai A. Hiller <[email protected]>
Signed-off-by: Kai A. Hiller <[email protected]>
Signed-off-by: Kai A. Hiller <[email protected]>
c6b4650
to
c67fb80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, thank you!
Nice to see some concurrency in the loading, even though this is probably quite a insignificant optimisation :D
Co-authored-by: Quentin Gliech <[email protected]>
4b44052
to
c5b1db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for doing this!
Code refactor of the config’s
secrets
section. Can be reviewed commit-by-commit.Benefits
validate
functionNoteworthy changes
futures
crate is added as a dependency to have access to the standard async toolstry_join
andtry_join_all
.