Fix spec compliance of upstream OAuth 2.0 client auth methods #4819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were sending the `client_id` in all cases, but the spec says it should only be sent for the `none` and `client_secret_post` methods.
sandhose
added
A-Upstream-OAuth
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
506f162
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e838090e.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-dont-send-client-id.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sending the
client_idin all cases, but the spec says itshould only be sent for the
noneandclient_secret_postmethods.