Update push rules for experimental MSC4306: Thread Subscriptions to follow newer draft. #18846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/msc4306_postcontent
branch
from
49ad465 to
8821d72
Compare
reivilibre
changed the title
reivilibre
force-pushed
the
rei/msc4306_postcontent
branch
from
8821d72 to
0aaab37
Compare
Signed-off-by: Olivier 'reivilibre <[email protected]>
reivilibre
force-pushed
the
rei/msc4306_postcontent
branch
from
0aaab37 to
3de8c21
Compare
anoadragon453
approved these changes
Aug 27, 2025
For what it's worth: I've added a few tests like that in the Rust SDK 1, which implements this MSC. The tests are checking that the subscribed-to threads will or will not generate notifications, for all combinations of "all messages" / "mentions only" / "mute", set globally or on a per-room basis. For "mute", as expected, these produce no notifications in all cases. What the new push rules fix, is that when a room or global is set to "mentions only", subscribed threads will trigger notifications (while they didn't, before this change). Footnotes
|
reivilibre
force-pushed
the
rei/msc4306_postcontent
branch
from
af7c437 to
2ca3ac4
Compare
2 tasks
reivilibre
force-pushed
the
rei/msc4306_postcontent
branch
from
7ae153d to
2ca3ac4
Compare
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 8, 2025
# Synapse 1.139.0 (2025-09-30) ## Features - Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](matrix-org/matrix-spec-proposals#4308) when [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) and [MSC4186: Simplified Sliding Sync](matrix-org/matrix-spec-proposals#4186) are enabled. ([\#18695](element-hq/synapse#18695)) - Update push rules for experimental [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) to follow a newer draft. ([\#18846](element-hq/synapse#18846)) - Add `get_media_upload_limits_for_user` and `on_media_upload_limit_exceeded` module API callbacks to the media repository. ([\#18848](element-hq/synapse#18848)) - Support [MSC4169](matrix-org/matrix-spec-proposals#4169) for backwards-compatible redaction sending using the `/send` endpoint. Contributed by @SpiritCroc @ Beeper. ([\#18898](element-hq/synapse#18898)) - Add an in-memory cache to `_get_e2e_cross_signing_signatures_for_devices` to reduce DB load. ([\#18899](element-hq/synapse#18899)) - Update [MSC4190](matrix-org/matrix-spec-proposals#4190) support to return correct errors and allow appservices to reset cross-signing keys without user-interactive authentication. Contributed by @tulir @ Beeper. ([\#18946](element-hq/synapse#18946)) ## Deprecations and Removals - Remove obsolete and experimental `/sync/e2ee` endpoint. ([\#18583](element-hq/synapse#18583)) # Synapse 1.138.0 (2025-09-09) ## Features - Support for the stable endpoint and scopes of [MSC3861](matrix-org/matrix-spec-proposals#3861) & co. ([\#18549](element-hq/synapse#18549))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows: #18762
Implements: MSC4306
Closes: #18431
Closes: #18437
Move the MSC4306 push rules to a new kind
postcontentPrevent users from creating user-defined
postcontentrules