Skip to content

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Oct 13, 2025

Revert "Move start_doing_background_updates() to SynapseHomeServer.start_background_tasks() (#19036)"

Why

See #19036 (comment)

Revert while I figure out the tests in #19057

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

….start_background_tasks()` (#19036)"

This reverts commit d399d76.
@MadLittleMods MadLittleMods marked this pull request as ready for review October 13, 2025 23:19
@MadLittleMods MadLittleMods requested a review from a team as a code owner October 13, 2025 23:19
@MadLittleMods MadLittleMods changed the title Revert "Move start_doing_background_updates() to SynapseHomeServerstart_background_tasks() (#19036)" Revert "Move start_doing_background_updates() to SynapseHomeServer.start_background_tasks() (#19036)" Oct 17, 2025
@MadLittleMods MadLittleMods merged commit eac8626 into develop Oct 20, 2025
21 of 22 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/revert-19036 branch October 20, 2025 15:55
Copy link
Contributor Author

@MadLittleMods MadLittleMods Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged as the change we're reverting shouldn't find it's way into an RC (release candidate) that will most likely happen tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant