Skip to content

Revert "Move start_doing_background_updates() to SynapseHomeServer.start_background_tasks() (#19036)" #19059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2025
Merged

Revert "Move start_doing_background_updates() to SynapseHomeServer.start_background_tasks() (#19036)" #19059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abc2a5f
Revert "Move `start_doing_background_updates()` to `SynapseHomeServer…
MadLittleMods Oct 13, 2025
9100563
Add temp changelog
MadLittleMods Oct 13, 2025
6021656
Merge branch 'develop' into madlittlemods/revert-19036
MadLittleMods Oct 17, 2025
623a748
Update comment with actual learnings from #19057
MadLittleMods Oct 17, 2025
ade8806
Remove changelog before merge
MadLittleMods Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion changelog.d/19036.misc
View file
Open in desktop
Copy link
Contributor Author

@MadLittleMods MadLittleMods Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged as the change we're reverting shouldn't find it's way into an RC (release candidate) that will most likely happen tomorrow.

This file was deleted.

8 changes: 3 additions & 5 deletions synapse/app/homeserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,6 @@ def start_listening(self) -> None:
# during parsing
logger.warning("Unrecognized listener type: %s", listener.type)

def start_background_tasks(self) -> None:
super().start_background_tasks()

self.get_datastores().main.db_pool.updates.start_doing_background_updates()


def load_or_generate_config(argv_options: List[str]) -> HomeServerConfig:
"""
Expand Down Expand Up @@ -435,6 +430,9 @@ async def _start_when_reactor_running() -> None:

await _base.start(hs, freeze)

# TODO: Feels like this should be moved somewhere else.
hs.get_datastores().main.db_pool.updates.start_doing_background_updates()

# Register a callback to be invoked once the reactor is running
register_start(hs, _start_when_reactor_running)

Expand Down
Loading