Skip to content

Fix CVE-2023-45803 and CVE-2024-37891 #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Filtzkowski-Robert-bah wants to merge 1 commit into from
Closed

Fix CVE-2023-45803 and CVE-2024-37891 #773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ pytest-xdist
pytest-parametrization
pytest-html
filelock
urllib3==2.0.6
urllib3
Copy link

@coderabbitai coderabbitai bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

❓ Verification inconclusive

Security fix is insufficient: unpinning does not guarantee CVE remediation.

CVE-2023-45803 requires urllib3 v1.26.18 or v2.0.7, and CVE-2024-37891 requires urllib3 version 1.26.19 or version 2.2.2. The original version 2.0.6 is vulnerable to both. However, removing the version pin entirely doesn't guarantee these fixes will be installed—any version of urllib3 (including vulnerable ones) could be resolved during pip install. This creates non-deterministic and potentially insecure dependency behavior across installations.

For proper security remediation in integration tests, specify a minimum version that contains both fixes (e.g., urllib3>=2.2.2) or document why a specific older version is acceptable.

Consider updating the requirement to:

-urllib3
+urllib3>=2.2.2

Or, if staying on the 2.0.x line is intentional, document that choice explicitly since the 2.x 2.0.7 version exists but CVE-2024-37891 is only fixed in 2.2.2.

I need to verify the CVE information before finalizing. Let me search for the specific vulnerability details.

Security fix is insufficient: unpinning does not guarantee CVE remediation.

CVE-2023-45803 has been addressed in versions 1.26.18 and 2.0.7, and CVE-2024-37891 requires either version 1.26.19 or version 2.2.2. The original pinned version 2.0.6 is vulnerable to both. However, removing the version pin entirely doesn't guarantee these fixes will be installed—any version of urllib3 (including vulnerable ones) could be resolved during pip install. This creates non-deterministic and potentially insecure dependency behavior across installations.

For proper security remediation in integration tests, specify a minimum version that contains both fixes (e.g., urllib3>=2.2.2), as the 2.0.x series does not have fixes for CVE-2024-37891.

Consider updating the requirement to:

-urllib3
+urllib3>=2.2.2
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
urllib3
urllib3>=2.2.2
🤖 Prompt for AI Agents 
integration_tests/requirements.txt around line 6: the dependency urllib3 was
unpinned which does not ensure CVE fixes; update the requirement to enforce a
minimum safe version that includes both CVE fixes (e.g., change the line to
require urllib3>=2.2.2) so pip cannot resolve a vulnerable release and
installations are deterministic with the patched version.