Pr 1669 lock files #1753
Merged
Pr 1669 lock files #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 @haritamar |
haritamar
commented
Nov 18, 2024
| dbt deps --lock --project-dir elementary/monitor/dbt_project && git diff --quiet elementary/monitor/dbt_project/package-lock.yml || (echo "Changes detected in package lock file!" && exit 1); | ||
| else | ||
| echo "Skipping hook, dbt version is $dbt_version (< 1.8)."; | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
Used chatgpt to generate this - basically verify that the lock is up to date, but only for dbt 1.8 and above (locks were introduced then)
MikaKerman
approved these changes
Nov 18, 2024
hanalytics-data-service
pushed a commit
to hanalytics-data-service/hanalytics-elementary
that referenced
this pull request
Apr 14, 2025
* add package-lock * update package-lock file * add dbt packages lock check to pre-commit --------- Co-authored-by: Noel Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null