Skip to content

Pr 1669 lock files #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haritamar merged 4 commits into from
Nov 18, 2024
Merged

Pr 1669 lock files #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eeda399
add package-lock
Aug 12, 2024
9b02105
Merge remote-tracking branch 'origin/master' into pr-1669-lock-files
haritamar Nov 18, 2024
3112564
update package-lock file
haritamar Nov 18, 2024
a90856f
add dbt packages lock check to pre-commit
haritamar Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ var/
logs/
.venv
poetry.lock
package-lock.yml

# PyInstaller
# Usually these files are written by a python script from a template
Expand Down Expand Up @@ -97,4 +96,4 @@ venv/

# elementary outputs
edr_target/
tests/tests_with_db/dbt_project/dbt_packages/
tests/tests_with_db/dbt_project/dbt_packages/
17 changes: 17 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,20 @@ repos:
entry: mypy --no-error-summary
language: system
files: ^elementary/.*\.py$

- repo: local
hooks:
- id: verify-dbt-project-packages-lock
name: Verify internal dbt project package lock
entry: |
bash -c '
dbt_version=$(python -c "from dbt.version import __version__; print(__version__)");
required_version="1.8";
if [[ $(echo -e "$dbt_version\n$required_version" | sort -V | tail -1) == "$dbt_version" ]]; then
dbt deps --lock --project-dir elementary/monitor/dbt_project && git diff --quiet elementary/monitor/dbt_project/package-lock.yml || (echo "Changes detected in package lock file!" && exit 1);
else
echo "Skipping hook, dbt version is $dbt_version (< 1.8).";
fi
Copy link
Collaborator Author

@haritamar haritamar Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used chatgpt to generate this - basically verify that the lock is up to date, but only for dbt 1.8 and above (locks were introduced then)

'
language: system
pass_filenames: false
6 changes: 6 additions & 0 deletions elementary/monitor/dbt_project/package-lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
packages:
- package: dbt-labs/dbt_utils
version: 0.8.6
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: 4c65ce164ff02dd816d0d311471e521cf0b7bd14
sha1_hash: d1378c3e1fda6c00a2e6cd156455d39cfc08a4d8
Loading