-
Notifications
You must be signed in to change notification settings - Fork 205
dbt-databricks must be <1.10.2 #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt-databricks must be <1.10.2 #1939
Conversation
WalkthroughThe change updates the dbt package version specifiers in the GitHub Actions workflow and the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 @arbiv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-warehouse.yml (1)
125-125: Clarify the TODO comment’s removal criteria
The workaround note is helpful, but add specific conditions or a target milestone/issue resolution date to ensure the TODO doesn’t linger indefinitely.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-warehouse.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: test (1.8.0, databricks_catalog) / test
- GitHub Check: test (1.8.0, athena) / test
- GitHub Check: test (1.8.0, bigquery) / test
- GitHub Check: test (athena) / test
- GitHub Check: test (redshift) / test
- GitHub Check: test (snowflake) / test
- GitHub Check: test (databricks_catalog) / test
- GitHub Check: test (bigquery) / test
- GitHub Check: test (1.8.0, snowflake) / test
- GitHub Check: test (postgres) / test
- GitHub Check: test (1.8.0, redshift) / test
- GitHub Check: test (1.8.0, postgres) / test
- GitHub Check: code-quality
🔇 Additional comments (1)
.github/workflows/test-warehouse.yml (1)
126-126: Verify the combined pip version specifier
Ensure thatdbt-databricks<1.10.2,~=…enforces the intended range under PEP 440 semantics.You can simulate resolution without modifying the repo:
#!/bin/bash # Verify pip resolves to the highest patch <1.10.2 pip download "dbt-databricks<1.10.2,~=1.10.1" --no-deps -d /tmp
4b3d76c to
b1c16b2
Compare
null
Summary by CodeRabbit
databricks_catalogwarehouse type to address a known issue.dbt-databricksdependency to maintain compatibility until the related issue is resolved.