updated package version #1950
updated package version #1950
Conversation
WalkthroughThe changes update the version of the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 @arbiv |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
elementary/monitor/dbt_project/packages.yml (1)
4-5: Pinning to a commit is fine, but add a short comment explaining why.Future maintainers will wonder why the normal
elementary-data/elementaryversion was replaced with a commit hash. A one-liner such as# Temporary pin – waiting for >0.19.0 with feature XYZprevents accidental upgrades or reverts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.yml(1 hunks)elementary/monitor/dbt_project/packages.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
elementary/monitor/dbt_project/packages.yml (1)
Learnt from: arbiv
PR: elementary-data/elementary#1937
File: elementary/clients/dbt/databricks_patch.py:99-124
Timestamp: 2025-06-19T09:03:56.968Z
Learning: For Databricks compatibility patches in elementary, prefer simple and permissive approaches over strict version checking. The patch should apply when the target module is available, regardless of version, as the defensive programming with exception handling and fallbacks makes it safe to use across versions.
elementary/monitor/dbt_project/package-lock.yml (1)
Learnt from: arbiv
PR: elementary-data/elementary#1937
File: elementary/clients/dbt/databricks_patch.py:99-124
Timestamp: 2025-06-19T09:03:56.968Z
Learning: For Databricks compatibility patches in elementary, prefer simple and permissive approaches over strict version checking. The patch should apply when the target module is available, regardless of version, as the defensive programming with exception handling and fallbacks makes it safe to use across versions.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test / test
- GitHub Check: code-quality
🔇 Additional comments (1)
elementary/monitor/dbt_project/package-lock.yml (1)
4-6: Manual verification required: update and commit lock-file SHA-1 checksumSince the sandbox couldn’t compute the SHA-1 or run
dbt deps --lock, please verify locally that your lock-file’ssha1_hashmatches the currentpackages.ymland regenerate if needed:• In your project directory (
elementary/monitor/dbt_project), compute the checksum (choose one):
sha1sum packages.yml- or
openssl dgst -sha1 packages.yml
• Compare the output to thesha1_hashvalue inpackage-lock.yml.
• If they differ, rundbt deps --lockto refresh the lock-file and then:git add elementary/monitor/dbt_project/package-lock.yml git commit -m "chore: update package-lock.yml SHA-1 checksum"This ensures dbt can install the updated git-based package.
arbiv
force-pushed
the
ele-4717-release-dbt-and-cli-0191
branch
from
ac57ead to
782d5dc
Compare
null
Summary by CodeRabbit