-
Notifications
You must be signed in to change notification settings - Fork 204
changed dbt package version to a commit with dremio types mapping. ne… #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eded for dremio cll in elementary cloud
|
Caution Review failedThe pull request is closed. WalkthroughSwitched the dbt dependency from the packaged elementary-data/elementary (v0.19.2) to the git-based elementary-data/dbt-data-reliability repository at revision 257974756e195140204ac4a76278a26acf78a27f in both packages.yml and package-lock.yml; updated the lock sha1 to 0bac331a6cf2d739e67a64cf27532d9502175e37. Other dependencies unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 @GuyEshdat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
elementary/monitor/dbt_project/packages.yml (1)
7-13: Optional: Update the commented “example” block to match current practice.The commented example still shows an older commit and the released package example. Consider updating the example comments to point at the new repo and a brief note why (Dremio types mapping, Pylon ticket ID) for future maintainers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.yml(1 hunks)elementary/monitor/dbt_project/packages.yml(1 hunks)
🔇 Additional comments (4)
elementary/monitor/dbt_project/packages.yml (2)
4-5: Git pin to dbt-data-reliability commit aligns with the PR goal.The switch from the released package to a specific revision of the repo is clear and tightly pinned. This should reliably pull in the Dremio types mapping needed for CLL.
4-5: Confirm package namespace to avoid breaking refs/macros.Ensure the dbt package at this revision declares name: "elementary" in its dbt_project.yml so existing refs/macros using the "elementary" namespace don’t break. If the package name differs, downstream references will fail.
elementary/monitor/dbt_project/package-lock.yml (2)
4-5: Lock entry mirrors packages.yml change.Git URL and revision are correctly reflected in the lock file. dbt_utils remains pinned to 0.8.6, which fits the declared constraint in packages.yml (>=0.8.0,<0.9.0).
6-6: ✅ Lock consistency verifiedAll checks passed between
packages.ymlandpackage-lock.yml:
- Git URL & revision match
dbt_utilsversion falls within the specified boundssha1_hashis a valid 40-hex string
…eded for dremio cll in elementary cloud
…eded for dremio cll in elementary cloud
Summary by CodeRabbit
Chores
Impact
Action Required