Skip to content

Conversation

@GuyEshdat
Copy link
Contributor

@GuyEshdat GuyEshdat commented Aug 17, 2025

…eded for dremio cll in elementary cloud

Summary by CodeRabbit

  • Chores

    • Switched the data reliability dependency to a pinned Git revision instead of a packaged release to ensure consistent builds.
    • No other dependencies changed.
  • Impact

    • No user-facing behavior changes expected; functionality remains the same.
    • Builds and environment consistency improved.
  • Action Required

    • None for end users.

@linear
Copy link

linear bot commented Aug 17, 2025

ELE-4931 dremio cll

@coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Switched the dbt dependency from the packaged elementary-data/elementary (v0.19.2) to the git-based elementary-data/dbt-data-reliability repository at revision 257974756e195140204ac4a76278a26acf78a27f in both packages.yml and package-lock.yml; updated the lock sha1 to 0bac331a6cf2d739e67a64cf27532d9502175e37. Other dependencies unchanged.

Changes

Cohort / File(s) Summary of Changes
Dependency switch to git-based dbt package
elementary/monitor/dbt_project/packages.yml, elementary/monitor/dbt_project/package-lock.yml
Replaced packaged elementary-data/elementary (version 0.19.2) with git dependency https://github.com/elementary-data/dbt-data-reliability.git at revision 257974756e195140204ac4a76278a26acf78a27f; updated lock entry sha1 from fb182360b3c74342aba55c5046a4139e2f1a6f2f to 0bac331a6cf2d739e67a64cf27532d9502175e37. No other dependency changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • michael-myaskovsky
  • haritamar
  • ofek1weiss

Poem

I nibble hashes and pin the vine,
Swapping crates for a branch so fine.
A carrot commit, a hops-and-click,
Revision set — the build feels slick.
Thump-thump, I merge; the tests align. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8036295 and 8cd1e0a.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml (1 hunks)
  • elementary/monitor/dbt_project/packages.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ele-4931-dremio-type-maping

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

👋 @GuyEshdat
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
elementary/monitor/dbt_project/packages.yml (1)

7-13: Optional: Update the commented “example” block to match current practice.

The commented example still shows an older commit and the released package example. Consider updating the example comments to point at the new repo and a brief note why (Dremio types mapping, Pylon ticket ID) for future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d9f145 and 8036295.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml (1 hunks)
  • elementary/monitor/dbt_project/packages.yml (1 hunks)
🔇 Additional comments (4)
elementary/monitor/dbt_project/packages.yml (2)

4-5: Git pin to dbt-data-reliability commit aligns with the PR goal.

The switch from the released package to a specific revision of the repo is clear and tightly pinned. This should reliably pull in the Dremio types mapping needed for CLL.


4-5: Confirm package namespace to avoid breaking refs/macros.

Ensure the dbt package at this revision declares name: "elementary" in its dbt_project.yml so existing refs/macros using the "elementary" namespace don’t break. If the package name differs, downstream references will fail.

elementary/monitor/dbt_project/package-lock.yml (2)

4-5: Lock entry mirrors packages.yml change.

Git URL and revision are correctly reflected in the lock file. dbt_utils remains pinned to 0.8.6, which fits the declared constraint in packages.yml (>=0.8.0,<0.9.0).


6-6: ✅ Lock consistency verified

All checks passed between packages.yml and package-lock.yml:

  • Git URL & revision match
  • dbt_utils version falls within the specified bounds
  • sha1_hash is a valid 40-hex string

@GuyEshdat GuyEshdat had a problem deploying to elementary_test_env August 17, 2025 14:20 — with GitHub Actions Failure
@GuyEshdat GuyEshdat merged commit 4288f49 into master Aug 17, 2025
3 of 5 checks passed
@GuyEshdat GuyEshdat deleted the ele-4931-dremio-type-maping branch August 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants