Update DBT package version #2012

elazarlachkar · 2025-09-17T12:15:23Z

null

Summary by CodeRabbit

Chores
- Updated an internal data-reliability dependency to a newer revision to align with upstream improvements.
- This maintenance update aims to improve stability, compatibility, and performance of monitoring workflows and may include upstream bug fixes and optimizations.
- No user-facing functional changes are expected; existing behavior should remain unchanged.

linear · 2025-09-17T12:15:26Z

coderabbitai · 2025-09-17T12:15:32Z

Walkthrough

Updated the git revision for the dbt-data-reliability dependency in elementary/monitor/dbt_project/packages.yml and the corresponding entry in elementary/monitor/dbt_project/package-lock.yml from cbabcb2c348be2b4c45ad72c3b94e7800a52a542 to 0f59f9f5407db890780f225f6c1e362f38221133.

Changes

Cohort / File(s)	Summary
Dependency revision bump (packages) `elementary/monitor/dbt_project/packages.yml`	Updated git ref for `https://github.com/elementary-data/dbt-data-reliability.git` to commit `0f59f9f5407db890780f225f6c1e362f38221133`.
Dependency revision bump (lockfile) `elementary/monitor/dbt_project/package-lock.yml`	Updated git revision and `sha1_hash` for the same git dependency to match commit `0f59f9f5407db890780f225f6c1e362f38221133` (sha1 -> `0dde8f6be0323bd473ea26bae571cef6d53d8fba`).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

update dbt package revision #2003 — Also updates the same git dependency revision to 0f59f9f5..., directly aligned with this change.
changed dbt package version to a commit with dremio types mapping. ne… #1985 — Previously modified the dbt-data-reliability git revision in packages.yml.
using elementary 0.19.0 #1942 — Related edits to the same dbt dependency entries (packages.yml / package-lock.yml).

Suggested reviewers

ofek1weiss
michael-myaskovsky

Poem

A rabbit taps the checksum stone,
Swaps a hash, then hops back home.
Two tidy lines in YAML beds,
Point our models to fresher heads.
Commit hopped in—now onward goes! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Update DBT package version" succinctly and accurately describes the primary change in this PR, which updates the dbt-data-reliability git dependency revision in elementary/monitor/dbt_project/packages.yml and the corresponding package-lock.yml, and is clear enough for a teammate scanning PR history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ele-5074-index-test_result_rows

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-17T12:15:35Z

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

elementary/monitor/dbt_project/packages.yml (1)
5-5: Prefer a tag/release over a raw commit when available (optional).

If a release tag exists for this SHA, consider switching to a tag for traceability and supply‑chain hygiene. Example:
-  - git: https://github.com/elementary-data/dbt-data-reliability.git
-    revision: 0f59f9f5407db890780f225f6c1e362f38221133
+  - git: https://github.com/elementary-data/dbt-data-reliability.git
+    tag: vX.Y.Z
If you want, I can look up whether this SHA corresponds to a released tag and suggest the exact value.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cf75564 and 9fe09fe.

📒 Files selected for processing (1)

elementary/monitor/dbt_project/packages.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: test / test
GitHub Check: code-quality

🔇 Additional comments (1)

elementary/monitor/dbt_project/packages.yml (1)

5-5: LGTM on the pin — commit present; regenerate & commit lockfile

Verified: commit 0f59f9f5407db890780f225f6c1e362f38221133 exists on the remote.

Action: elementary/monitor/dbt_project/packages.lock not found — run (cd elementary/monitor/dbt_project && dbt deps) and commit the generated packages.lock; ensure it pins the above SHA.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

elementary/monitor/dbt_project/package-lock.yml (1)

5-6: Prefer regenerating the lock via dbt, not manual edits.

To avoid drift and checksum mistakes, update packages.yml and then run dbt deps to regenerate package-lock.yml (commit both files). Consider adding a CI check that runs dbt deps and fails if the lock changes.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe09fe and 56d8f23.

📒 Files selected for processing (1)

elementary/monitor/dbt_project/package-lock.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: test / test
GitHub Check: code-quality

🔇 Additional comments (1)

elementary/monitor/dbt_project/package-lock.yml (1)

5-6: Verify pinned git revision and tarball SHA1

packages.yml and package-lock.yml both point to revision 0f59f9f5407db890780f225f6c1e362f38221133 and package-lock lists sha1_hash 0dde8f6be0323bd473ea26bae571cef6d53d8fba. The sandbox could not download the GitHub tarball due to SSL certificate verification errors, so the sha1 could not be validated. Re-run the verification script (or download the archive for that commit locally/CI and compute the SHA‑1) and confirm the computed hash matches the lock; if it does not, regenerate package-lock.yml or update the hash.

coderabbitai · 2025-09-17T12:31:21Z

elementary/monitor/dbt_project/package-lock.yml

-    revision: cbabcb2c348be2b4c45ad72c3b94e7800a52a542
-sha1_hash: 90d912df8d9c6a435f1936c7d93e4bf6c0efc4dd
+    revision: 0f59f9f5407db890780f225f6c1e362f38221133
+sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba


⚠️ Potential issue

Fix YAML indentation for sha1_hash (breaks parsing).

sha1_hash must be nested under the same list item as git and revision. It’s currently top‑level due to missing indentation and will cause YAML parse errors / dbt to ignore the lock entry.

Apply this diff:

-sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba + sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba

sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba

🤖 Prompt for AI Agents

In elementary/monitor/dbt_project/package-lock.yml around line 6, the sha1_hash key is incorrectly placed at top level instead of nested under the same list item as git and revision; indent sha1_hash so it is a child of the same mapping that contains git and revision (match the indentation level of git/revision for that list entry) so the YAML parser and dbt will associate the hash with the correct package entry.

Update DBT package version

9fe09fe

elazarlachkar self-assigned this Sep 17, 2025

arbiv self-requested a review September 17, 2025 12:16

arbiv approved these changes Sep 17, 2025

View reviewed changes

coderabbitai bot reviewed Sep 17, 2025

View reviewed changes

Updated lock file as well

56d8f23

coderabbitai bot reviewed Sep 17, 2025

View reviewed changes

Merge branch 'master' into ele-5074-index-test_result_rows

13e81d5

elazarlachkar merged commit acdac83 into master Sep 17, 2025
7 checks passed

elazarlachkar deleted the ele-5074-index-test_result_rows branch September 17, 2025 14:01

coderabbitai bot mentioned this pull request Sep 28, 2025

Updated DBT pacakge revision #2017

Merged

This was referenced Oct 9, 2025

update the CLI to use the new package version #2024

Merged

changed the dbt package version to a version that fixed a dremio time… #2033

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update DBT package version #2012

Update DBT package version #2012

Uh oh!

elazarlachkar commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Sep 17, 2025

Uh oh!

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba
	sha1_hash: 0dde8f6be0323bd473ea26bae571cef6d53d8fba

Update DBT package version #2012

Update DBT package version #2012

Uh oh!

Conversation

elazarlachkar commented Sep 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Sep 17, 2025

Uh oh!

coderabbitai bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elazarlachkar commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 17, 2025 •

edited

Loading