Skip to content

Include popovers and menus in window screenshots#2716

Open
lenemter wants to merge 6 commits intomainfrom
lenemter/wip-better-screenshot
Open

Include popovers and menus in window screenshots#2716
lenemter wants to merge 6 commits intomainfrom
lenemter/wip-better-screenshot

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Jan 6, 2026

Fixes #824

@lenemter lenemter requested a review from a team January 6, 2026 11:17
@lenemter lenemter requested a review from leolost2605 January 6, 2026 12:47
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When screen shotting any app I only get the top left corner:
Screenshot from 2026-01-06 17 22 54@1x

This happens regardless of whether a menu is open. I'm running 1.25 scale. However the correct area get's flashed afaict.

@lenemter lenemter force-pushed the lenemter/wip-better-screenshot branch from 130f399 to 243db82 Compare January 20, 2026 19:15
@danirabbit danirabbit mentioned this pull request Jan 21, 2026
@lenemter lenemter force-pushed the lenemter/wip-better-screenshot branch 2 times, most recently from 71c0d58 to ebf6f29 Compare January 21, 2026 18:50
@lenemter
Copy link
Member Author

@leolost2605 Should be fixed now!

@lenemter lenemter force-pushed the lenemter/wip-better-screenshot branch from ebf6f29 to 9beff64 Compare January 23, 2026 15:41
@danirabbit
Copy link
Member

@leolost2605 can we get a re-review here? :)

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code supposed to adjust the image size to be able to include all transients? If not I think it maybe should? Otherwise it doesn't look quite right: (I'm running 1.25 x scaling if that matters)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Current window" doesn't include children like popovers

3 participants