Skip to content

Don't set window position #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsdc merged 2 commits into from
Apr 3, 2025
Merged

Don't set window position #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d089cff
Don't set window position
danirabbit Apr 1, 2025
5eeae14
Merge branch 'dev' into danirabbit/schema-rm-position
stsdc Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions data/io.elementary.monitor.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,6 @@
<summary>Window height</summary>
<description>Window height</description>
</key>
<key type="i" name="position-x">
<default>-1</default>
<summary>Window X position</summary>
<description>Window X position</description>
</key>
<key type="i" name="position-y">
<default>-1</default>
<summary>Window Y position</summary>
<description>Window Y position</description>
</key>
<key type='b' name="indicator-state">
<default>false</default>
<summary>To show Monitor Indicator or not</summary>
Expand Down
14 changes: 1 addition & 13 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,10 @@ public class Monitor.MainWindow : Hdy.ApplicationWindow {
key_press_event.connect ((e) => shortcuts.handle (e));

this.delete_event.connect (() => {
int window_width, window_height, position_x, position_y;
int window_width, window_height;
get_size (out window_width, out window_height);
get_position (out position_x, out position_y);
MonitorApp.settings.set_int ("window-width", window_width);
MonitorApp.settings.set_int ("window-height", window_height);
MonitorApp.settings.set_int ("position-x", position_x);
MonitorApp.settings.set_int ("position-y", position_y);
MonitorApp.settings.set_boolean ("is-maximized", this.is_maximized);

MonitorApp.settings.set_string ("opened-view", stack.visible_child_name);
Expand All @@ -160,15 +157,6 @@ public class Monitor.MainWindow : Hdy.ApplicationWindow {
if (MonitorApp.settings.get_boolean ("is-maximized")) {
this.maximize ();
}

int position_x = MonitorApp.settings.get_int ("position-x");
int position_y = MonitorApp.settings.get_int ("position-y");
if (position_x == -1 || position_y == -1) {
// -1 is default value of these keys, which means this is the first launch
this.window_position = Gtk.WindowPosition.CENTER;
} else {
move (position_x, position_y);
}
}

}