feat: add vietnamese #18
Conversation
WalkthroughThis change updates the Changes
Assessment against linked issues
Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| import requests | ||
|
|
||
| language_codes = ['ENG', 'HIN', 'TGL', 'THA'] | ||
| language_codes = ['ENG', 'HIN', 'TGL', 'THA', 'VIE'] |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fantastic addition of Vietnamese language support! This update broadens the scope of simulated events to include VIE, aligning perfectly with elimu.ai’s mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.
Let’s also verify that the lang-VIE branch and its videos.csv exist in the webapp-lfs repo to avoid broken URLs:
🏁 Script executed:
#!/bin/bash
# Verify that the lang-VIE branch exists and videos.csv is accessible
gh api -H "Accept: application/vnd.github.v3+json" /repos/elimu-ai/webapp-lfs/branches/lang-VIE \
&& curl -Is https://raw.githubusercontent.com/elimu-ai/webapp-lfs/refs/heads/main/lang-VIE/videos.csv | head -n 1Length of output: 256
Let’s correct the URL and re‑check that the lang‑VIE branch and its videos.csv file actually exist:
🏁 Script executed:
#!/bin/bash
# Re-verify that the lang-VIE branch exists and that videos.csv is accessible
gh api -H "Accept: application/vnd.github.v3+json" /repos/elimu-ai/webapp-lfs/branches/lang-VIE
curl -Is https://raw.githubusercontent.com/elimu-ai/webapp-lfs/lang-VIE/videos.csv | head -n 1Length of output: 365
Ensure lang-VIE branch and videos.csv exist in webapp-lfs
During verification, the GitHub API returned a 404 for /branches/lang-VIE and the raw URL for lang-VIE/videos.csv also 404’d. To avoid broken links and keep everything in sync, please:
- Create and push the
lang‑VIEbranch in theelimu-ai/webapp-lfsrepository. - Commit and push the corresponding
videos.csvfile on that branch so the URL resolves properly.
This will solidify the new Vietnamese support in simulate-video-learning-events.py and help uphold elimu.ai’s mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.
Issue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Summary by CodeRabbit