Skip to content

feat: add vietnamese #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

feat: add vietnamese #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simulate-video-learning-events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import random
import requests

language_codes = ['ENG', 'HIN', 'TGL', 'THA']
language_codes = ['ENG', 'HIN', 'TGL', 'THA', 'VIE']
Copy link
Contributor

@coderabbitai coderabbitai bot Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Fantastic addition of Vietnamese language support! This update broadens the scope of simulated events to include VIE, aligning perfectly with elimu.ai’s mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

Let’s also verify that the lang-VIE branch and its videos.csv exist in the webapp-lfs repo to avoid broken URLs:

🏁 Script executed:

#!/bin/bash
# Verify that the lang-VIE branch exists and videos.csv is accessible
gh api -H "Accept: application/vnd.github.v3+json" /repos/elimu-ai/webapp-lfs/branches/lang-VIE \
  && curl -Is https://raw.githubusercontent.com/elimu-ai/webapp-lfs/refs/heads/main/lang-VIE/videos.csv | head -n 1

Length of output: 256

Let’s correct the URL and re‑check that the lang‑VIE branch and its videos.csv file actually exist:

🏁 Script executed:

#!/bin/bash
# Re-verify that the lang-VIE branch exists and that videos.csv is accessible
gh api -H "Accept: application/vnd.github.v3+json" /repos/elimu-ai/webapp-lfs/branches/lang-VIE
curl -Is https://raw.githubusercontent.com/elimu-ai/webapp-lfs/lang-VIE/videos.csv | head -n 1

Length of output: 365

Ensure lang-VIE branch and videos.csv exist in webapp-lfs

During verification, the GitHub API returned a 404 for /branches/lang-VIE and the raw URL for lang-VIE/videos.csv also 404’d. To avoid broken links and keep everything in sync, please:

  • Create and push the lang‑VIE branch in the elimu-ai/webapp-lfs repository.
  • Commit and push the corresponding videos.csv file on that branch so the URL resolves properly.

This will solidify the new Vietnamese support in simulate-video-learning-events.py and help uphold elimu.ai’s mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

print(basename(__file__), f'language_codes: {language_codes}')

android_ids = ['e387e38700000001', 'e387e38700000002', 'e387e38700000003']
Expand Down