Skip to content

Improve Enum.min_max/1,2,3 specs and docs #14697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Improve Enum.min_max/1,2,3 specs and docs #14697

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eea5d7
Improve Enum.min_max/1,2,3 specs and docs
michallepicki Aug 5, 2025
f83d5e7
Apply suggestions from code review
josevalim Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/elixir/lib/enum.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2187,20 +2187,19 @@ defmodule Enum do
nil

"""
@spec min_max(t, (element, element -> boolean) | module()) ::
@spec min_max(t) :: {element, element}
@spec min_max(t, (element, element -> boolean) | module()) :: {element, element}
@spec min_max(t, (-> empty_result)) :: {element, element} | empty_result when empty_result: any
@spec min_max(t, (element, element -> boolean) | module(), (-> empty_result)) ::
{element, element} | empty_result
when empty_result: any
@spec min_max(
t,
(element, element -> boolean) | module(),
(-> empty_result)
) :: {element, element} | empty_result
when empty_result: any

def min_max(enumerable) do
min_max(enumerable, fn -> raise Enum.EmptyError end)
end

def min_max(enumerable, sorter_or_empty_fallback)

def min_max(first..last//step = range, empty_fallback)
when is_function(empty_fallback, 0) do
case Range.size(range) do
Expand Down