Improve Enum.min_max/1,2,3 specs and docs #14697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add min_max/1 spec for confirming quickly that it returns a tuple - Add back min_max/2 spec for the empty_result fallback clause, as a separate spec with non overlapping domain - Add min_max/2 empty head so that the doc shows 2nd arg as sorter_or_empty_fallback and not just empty_fallback from the first clause
josevalim
reviewed
Aug 5, 2025
josevalim
reviewed
Aug 5, 2025
|
💚 💙 💜 💛 ❤️ |
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
- Add back min_max/2 spec for the empty_result fallback clause, as a separate spec with non overlapping domain - Merge min_max/1 and min_max/2 definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(min_max/3 spec didn't change, was only re-formatted for compactness)