feat: windows support #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
mhanberg
reviewed
Nov 19, 2025
This comment was marked as resolved.
This comment was marked as resolved.
doorgan
force-pushed
the
doorgan/windows-support
branch
5 times, most recently
from
43c27ad to
c938c4a
Compare
mhanberg
reviewed
Nov 20, 2025
Collaborator
Author
|
There's a few tests failing on windows that I need to fix but this puppy can run |
doorgan
commented
Nov 21, 2025
Comment on lines
-168
to
-180
| defp app_globs do | ||
| app_globs = Enum.map(@allowed_apps, fn app_name -> "/**/#{app_name}*/ebin" end) | ||
| ["/**/priv" | app_globs] | ||
| end | ||
|
|
||
| def glob_paths(_) do | ||
| entries = | ||
| for entry <- :code.get_path(), | ||
| entry_string = List.to_string(entry), | ||
| entry_string != ".", | ||
| Enum.any?(app_globs(), &PathGlob.match?(entry_string, &1, match_dot: true)) do | ||
| entry | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
Windows was not finding the files on windows with the old code
doorgan
force-pushed
the
doorgan/windows-support
branch
from
3b99b09 to
c476bd9
Compare
I got tired of building burrito releases on windows
This is the same method Livebook uses for the very same reasons
doorgan
force-pushed
the
doorgan/windows-support
branch
3 times, most recently
from
0f11f1a to
9269f26
Compare
Member
|
Is this ready for review? |
Collaborator
Author
|
@mhanberg almost, there's a few failing tests on windows I'm fixing. I'll tag you when it is. |
doorgan
force-pushed
the
doorgan/windows-support
branch
from
9269f26 to
bf7cb5f
Compare
doorgan
force-pushed
the
doorgan/windows-support
branch
from
86651c4 to
1e93243
Compare
Collaborator
Author
|
@mhanberg it's ready for review now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Windows
Closes #89
Fixes #60
Also adds a
just start-tcptask to start a plain release in TCP mode for development because expert builds burrito releases SO SLOW on my windows machine that it spent more time waiting for the build than actually working on the relevant changesOne note here is that this implementation uses the user's globally installed elixir on Windows. I don't know if there's any version manager like mise/asdf/nix on windows, if there is we'll need to get the PATH for the project folder like we do for Unix
Another note is that for reasons I don't yet understand windows is way slower than unix even on my beefy machine, so I had to increase the timeouts for a few tests. I was also seeing a few timing issues due to this that I hope were reliably mitigated.