-
Notifications
You must be signed in to change notification settings - Fork 16
Updated dependencies #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #362
Conversation
e32ef6b to
7101ae9
Compare
7101ae9 to
f39e29b
Compare
d78b445 to
bf742c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you rebase? I'm surprised this diff is still here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I did rebase after #363 had been merged.
I'm not sure what about the diff surprised you. It looks okay to me (i.e. the changes to this file are what I had intended). Can you clarify for me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I guess I'm surprisde there is still non-dependency updates in the dependency update PR.
since the refactor is related to content-tag, it should be in a separate PR, and maybe content-tag updating also be in a separate PR.
This PR is in conflict tho -- I pulled some of your changes out to another PR, #365
thanks for doing this! It's good to get things updated.
With #365 merged, this #362 will be a bit smaller, and we can keep iterating 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. See #366.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! now this one has conflicts 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem.
f77ea90 to
22f4ae1
Compare
fb26015 to
bdfe347
Compare
bdfe347 to
d459309
Compare
| "eslint-plugin-n": "^17.12.0", | ||
| "eslint": "^9.28.0", | ||
| "eslint-config-prettier": "^10.1.5", | ||
| "eslint-plugin-jsdoc": "^50.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, v51.0.0 drops support Node 18.
https://github.com/gajus/eslint-plugin-jsdoc/releases/tag/v51.0.0
d459309 to
73e3df4
Compare
Background
A few dependencies have had a major release:
content-tageslintpnpmprettier(likely some breaking changes in a minor version)typescript-eslintvitestBy updating these to the latest version, we can continue to maintain this project.