Skip to content

Refactored code #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NullVoxPopuli merged 5 commits into from
Jun 6, 2025
Merged

Refactored code #363

NullVoxPopuli merged 5 commits into from
Jun 6, 2025

Conversation

@ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented Jun 6, 2025 •
edited
Loading

Background

Prep work for #362. Should reduce noise.

@ijlee2 ijlee2 marked this pull request as ready for review June 6, 2025 12:00
@NullVoxPopuli
Copy link
Member

NullVoxPopuli commented Jun 6, 2025

thanks for pulling this out!

@NullVoxPopuli NullVoxPopuli merged commit a35e891 into ember-tooling:main Jun 6, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jun 6, 2025
Merged
@ijlee2
Copy link
Contributor Author

ijlee2 commented Jun 6, 2025

Thanks for your help with reviewing both PRs. Separating the refactor definitely made the update PR cleaner.

@ijlee2 ijlee2 deleted the refactor-code branch June 6, 2025 16:29
@ijlee2 ijlee2 mentioned this pull request Jun 10, 2025
Merged
@NullVoxPopuli NullVoxPopuli added the internal Internal changes that still require a mention in the changelog/release notes label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees

No one assigned

Labels

internal Internal changes that still require a mention in the changelog/release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijlee2 @NullVoxPopuli