fix reload with ember-debug #2701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused variable declaration for emberDebug.
Contributor
|
@patricklx what was the status on this one? I remember from the tooling team meeting, we discovered that this doesn't actually fix the problem? is that true? am I misremembering? |
Collaborator
Author
|
I think it was discussed last week and this fix is okay but not the best. The correct fix needs better integration with ember source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ember inspector has an option to reload the website with ember-debug.
that is to e.g. catch early rendering for performance page, or catch early deprecation messages.
that will now not work anymore, as ember-debug is ESM. We should either bundle it OR use
import().i think
import()would be the quick fix.but a bundle is preferred , as the intention is to have
ember-debugfully loaded BEFORE emberScreenshots