Skip to content

fix reload with ember-debug #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix reload with ember-debug #2701

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b05ebe5
fix reload with ember-debug
patricklx Oct 28, 2025
0db51a3
fix
patricklx Oct 28, 2025
269e459
remove comment
patricklx Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 4 additions & 23 deletions app/services/adapters/web-extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { tracked } from '@glimmer/tracking';

import BasicAdapter from './basic';
import config from 'ember-inspector/config/environment';
import type { Message } from '../port';

let emberDebug: string | null = null;

export default class WebExtension extends BasicAdapter {
@tracked canOpenResource = false;
name = 'web-extension';
Expand Down Expand Up @@ -145,27 +142,11 @@ export default class WebExtension extends BasicAdapter {

function loadEmberDebug() {
const minimumVersion = config.emberVersionsSupported[0].replace(/\./g, '-');
let xhr: XMLHttpRequest;

return new Promise((resolve) => {
if (!emberDebug) {
xhr = new XMLHttpRequest();
xhr.open(
'GET',
chrome.runtime.getURL(`/panes-${minimumVersion}/ember_debug.js`),
);
xhr.onload = function () {
if (xhr.readyState === 4) {
if (xhr.status === 200) {
emberDebug = xhr.responseText;
resolve(emberDebug);
}
}
};

xhr.send();
} else {
resolve(emberDebug);
}
const url = chrome.runtime.getURL(
`/panes-${minimumVersion}/ember_debug.js`,
);
resolve(`import('${url}')`);
});
}