Add types for object based test.each() datasets#1197
Merged
NullVoxPopuli merged 1 commit intoemberjs:mainfrom Sep 12, 2025
Merged
Add types for object based test.each() datasets#1197NullVoxPopuli merged 1 commit intoemberjs:mainfrom
NullVoxPopuli merged 1 commit intoemberjs:mainfrom
Conversation
Prior to this change, we only supported an array for the dataset type which causes the original `qunit` type definitions to resolve if the dataset is an object. The fallback will result in the `TestContect` being removed from the `this` and marking it as `any`. According the QUnit docs if you pass an object instead of an array to test.each() the keys of the object become the test label while the values are the data passed to each run of the test. This change unions the T[] with Record<string, T> so that both options can be used as expected.
NullVoxPopuli
approved these changes
Sep 12, 2025
Collaborator
|
gonna toggle the PR to trick CI in to running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, we only supported an array for the dataset type which causes the original
qunittype definitions to resolve if the dataset is an object. The fallback will result in theTestContectbeing removed from thethisand marking it asany.According the QUnit docs if you pass an object instead of an array to test.each() the keys of the object become the test label while the values are the data passed to each run of the test.
This change unions the
T[]withRecord<string, T>so that both options can be used as expected.