Skip to content

Add types for object based test.each() datasets #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 1 commit into from
Sep 12, 2025
Merged

Add types for object based test.each() datasets #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ declare global {
interface EachFunction {
<TC extends TestContext, T>(
name: string,
dataset: T[],
dataset: T[] | Record<string, T>,
callback: (this: TC, assert: Assert, data: T) => void | Promise<unknown>
): void;
}
Expand Down
11 changes: 10 additions & 1 deletion test-types/src/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,16 @@ module('with setup options', function(hooks) {
});

module('methods on test function', function() {
test.each('example with each', [1, 2, 3], async function(assert, number) {
test.each('example with each (array dataset)', [1, 2, 3], async function(assert, number) {
// setup the outer context
this.set('value', 'cat');

await render(hbs`{{number}}`);

assert.strictEqual(number, 1)
});

test.each('example with each (object dataset)', { one: 1, two: 2, three: 3 }, async function(assert, number) {
// setup the outer context
this.set('value', 'cat');

Expand Down
Loading