Fix: Account for !important tag when checking for content text being quoted properly#3313
Open
amubushar wants to merge 1 commit intoemotion-js:mainfrom
Open
Fix: Account for !important tag when checking for content text being quoted properly#3313amubushar wants to merge 1 commit intoemotion-js:mainfrom
amubushar wants to merge 1 commit intoemotion-js:mainfrom
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Currently, CSS that uses content with quoted text followed by an !important tag breaks in development mode:
e.g
css={{ content: "'•' !important" }}as mentioned in #3183.Why:
This is because we currently check for quoted content by matching the starting character and ending character of the content, however with an !important tag added it will no longer match correctly.
How:
We now identify the first quote character, find its last occurrence and then check if the remainder after last occurrence is !important, if it is we no longer error incorrectly.