Skip to content

Fix: Account for !important tag when checking for content text being quoted properly #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

Fix: Account for !important tag when checking for content text being quoted properly #3313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/serialize/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,28 @@ if (isDevelopment) {

processStyleValue = (key: string, value: string | number) => {
if (key === 'content') {
let isProperlyQuoted = false
if (typeof value === 'string') {
const first = value.charAt(0)
if ((first === '"' || first === "'") && value.length > 1) {
const closingIndex = value.lastIndexOf(first)
if (closingIndex > 0) {
const remainder = value.slice(closingIndex + 1).trim()
if (
closingIndex === value.length - 1 ||
remainder === '' ||
remainder === '!important'
) {
isProperlyQuoted = true
}
}
}
}
if (
typeof value !== 'string' ||
(contentValues.indexOf(value) === -1 &&
!contentValuePattern.test(value) &&
(value.charAt(0) !== value.charAt(value.length - 1) ||
(value.charAt(0) !== '"' && value.charAt(0) !== "'")))
!isProperlyQuoted)
) {
throw new Error(
`You seem to be using a value for 'content' without quotes, try replacing it with \`content: '"${value}"'\``
Expand Down