Re-enable test_pthread_create_standalone #19505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jun 1, 2023
|
Looks like this test still timed out on wasm64 (https://app.circleci.com/pipelines/github/emscripten-core/emscripten/28241/workflows/3ee98437-344e-43ec-aa8f-d5212a626ffe/jobs/641185). i'll retry to see if it's flake or consistent. |
kripken
approved these changes
Jun 1, 2023
Assuming updating node took care of the flakiness, this will fix #18405
|
Can we rebase this an try it again? |
|
Looks like it still timed out on core2 and core3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming updating node took care of the flakiness, this will fix #18405