Skip to content

Re-enable test_pthread_create_standalone #19505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Re-enable test_pthread_create_standalone #19505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d18a98d
Re-enable test_pthread_create_standalone
dschuff Jun 1, 2023
d6abee9
Merge branch 'main' into reenable
dschuff Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9088,11 +9088,7 @@ def test_fpic_static(self):
self.emcc_args.append('-fPIC')
self.do_core_test('test_hello_world.c')

# Marked as impure since we don't have a wasi-threads is still
# a WIP.
# Test is disabled on standalone because of flakes, see
# https://github.com/emscripten-core/emscripten/issues/18405
# @also_with_standalone_wasm(impure=True)
@also_with_standalone_wasm(impure=True)
@node_pthreads
def test_pthread_create(self):
# test that the node environment can be specified by itself, and that still
Expand Down
Loading