Skip to content

Conversation

Peter0x44
Copy link
Contributor

@Peter0x44 Peter0x44 commented Sep 3, 2024

Currently, users who run emcmake without cmake on the PATH are greeted with confusing errors like:

emcmake cmake ..
configure: cmake .. -DCMAKE_TOOLCHAIN_FILE=D:\src\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=D:/src/emsdk/node/18.20.3_64bit/bin/node.exe -G Ninja emcmake: error: 'cmake .. -DCMAKE_TOOLCHAIN_FILE=D:\src\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=D:/src/emsdk/node/18.20.3_64bit/bin/node.exe -G Ninja' failed: [WinError 2] The system cannot find the file specified

@Peter0x44
Copy link
Contributor Author

Peter0x44 commented Sep 3, 2024

I'm not sure if users have any reason not to have CMake on their PATH, maybe the error could be adjusted to only happen if argv[0] == "cmake" or so.

Also, open to suggestions to change the wording.

@sbc100 sbc100 enabled auto-merge (squash) September 3, 2024 21:45
auto-merge was automatically disabled September 3, 2024 23:26

Head branch was pushed to by a user without write access

Currently, users who run emcmake without cmake on the PATH are greeted
with confusing errors like:

emcmake cmake ..
configure: cmake .. -DCMAKE_TOOLCHAIN_FILE=D:\src\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=D:/src/emsdk/node/18.20.3_64bit/bin/node.exe -G Ninja
emcmake: error: 'cmake .. -DCMAKE_TOOLCHAIN_FILE=D:\src\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=D:/src/emsdk/node/18.20.3_64bit/bin/node.exe -G Ninja' failed: [WinError 2] The system cannot find the file specified
@sbc100 sbc100 enabled auto-merge (squash) July 16, 2025 22:10
@Peter0x44
Copy link
Contributor Author

I think some flaky install for a test failed and stopped this from getting merged.

Failures
 - ninja (exited 1) - ninja not installed. An error occurred during installation:
 Error downloading 'ninja.1.13.1' from 'https://community.chocolatey.org/api/v2/package/ninja/1.13.1'.
 - pkgconfiglite (exited 1) - pkgconfiglite not installed. An error occurred during installation:
 Error downloading 'pkgconfiglite.0.28.0' from 'https://community.chocolatey.org/api/v2/package/pkgconfiglite/0.28'.

@sbc100 sbc100 disabled auto-merge July 21, 2025 20:45
@sbc100 sbc100 merged commit c7b8e3f into emscripten-core:main Jul 21, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants