Skip to content

Check if cmake is on the PATH in emcmake.py #22489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

Check if cmake is on the PATH in emcmake.py #22489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
512287a
Check if cmake is on the PATH in emcmake.py
Peter0x44 Sep 3, 2024
3c99d7b
Use dirname instead of isabs in case the path to the cmake executable…
Peter0x44 Jul 16, 2025
4bc07c6
Write error message to stderr
Peter0x44 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions emcmake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ def has_substr(args, substr):
# See https://github.com/emscripten-core/emscripten/issues/15522
args.append(f'-DCMAKE_CROSSCOMPILING_EMULATOR={node_js}')

# Print a better error if we have no CMake executable on the PATH
if not os.path.dirname(args[0]) and not shutil.which(args[0]):
print(f'emcmake: cmake executable not found on PATH: `{args[0]}`', file=sys.stderr)
return 1

# On Windows specify MinGW Makefiles or ninja if we have them and no other
# toolchain was specified, to keep CMake from pulling in a native Visual
# Studio, or Unix Makefiles.
Expand Down
Loading