Skip to content

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 3, 2024

See #19375

@sbc100 sbc100 requested review from juj and kripken September 3, 2024 18:11
@juj
Copy link
Collaborator

juj commented Sep 3, 2024

Did the @crossplatform directive I added get ignored without this? LGTM

@sbc100 sbc100 force-pushed the crossplatform_sanity branch from 05a026a to 48cd119 Compare September 3, 2024 19:07
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 3, 2024

Did the @crossplatform directive I added get ignored without this? LGTM

yes, the --crossplatform-only flag (and thus the attribute that controls it) was previously only used for core0 and other tests.

@sbc100 sbc100 merged commit 3e76938 into emscripten-core:main Sep 3, 2024
2 checks passed
@sbc100 sbc100 deleted the crossplatform_sanity branch September 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants