Fix freetype build on windows and mark test as crossplaform #22602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
force-pushed
the
freetype_crossplatform
branch
7 times, most recently
from
9bf7d79 to
83d2848
Compare
sbc100
changed the title
dschuff
reviewed
Sep 20, 2024
.circleci/config.yml
Outdated
| - run-tests: | ||
| title: "crossplatform tests" | ||
| test_targets: "--crossplatform-only" | ||
| test_targets: "other.test_freetype_emscripten" |
The subprocess creation on windows really doesn't like it when an argument contains < or >. Instead of trying to defined `FT_CONFIG_CONFIG_H` or point to our own version, just overwrite the default version. See emscripten-core#22585 (comment)
sbc100
force-pushed
the
freetype_crossplatform
branch
from
83d2848 to
5d7c55e
Compare
kripken
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subprocess creation on windows really doesn't like it when an
argument contains < or >. Instead use the default
FT_CONFIG_CONFT_CONFIG_CONFIG_Hand define the twoHAVE_macros on the command line.See #22585 (comment)