Allow pthread programs to run without SharedArrayBuffer #22710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
SharedArrayBuffer
branch
from
2565907 to
e09fde4
Compare
kripken
reviewed
Oct 10, 2024
sbc100
force-pushed
the
SharedArrayBuffer
branch
2 times, most recently
from
0d6979f to
a52cc74
Compare
As long as they don't actually try to start any threads there is no reason to prevent them from running/starting. Such programs will now instead fail when they first try to create a thread. This is useful for programs that are built with threading support but might also want to run in environments without SharedArrayBuffer, e.g. when deployed without COOP/COEP.
sbc100
force-pushed
the
SharedArrayBuffer
branch
from
a52cc74 to
3d7f0b3
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 11, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 11, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 11, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 11, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 14, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 14, 2024
This should have been part of emscripten-core#22710
sbc100
added a commit
that referenced
this pull request
Oct 15, 2024
This should have been part of #22710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as they don't actually try to start any threads there is no
reason to prevent them from running/starting.
Such programs will now instead fail when they first try to create
a thread.
This is useful for programs that are built with threading support but
might also want to run in environments without SharedArrayBuffer,
e.g. when deployed without COOP/COEP.