Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 10, 2024

No description provided.

@sbc100 sbc100 requested a review from brendandahl October 10, 2024 21:11
@sbc100 sbc100 changed the title [embind] Fix type in overloadTable error checking. NFC [embind] Fix typo in overloadTable error checking. NFC Oct 10, 2024
@sbc100 sbc100 requested a review from kripken October 10, 2024 22:29
@sbc100 sbc100 requested a review from kripken October 11, 2024 17:01
@sbc100 sbc100 force-pushed the overloadTable branch 2 times, most recently from 0ba8377 to ca959ae Compare October 11, 2024 23:13
@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 14, 2024

This is now a minor codesize win!

@sbc100 sbc100 enabled auto-merge (squash) October 14, 2024 22:33
@sbc100 sbc100 disabled auto-merge October 14, 2024 23:42
@sbc100 sbc100 merged commit 97700f1 into emscripten-core:main Oct 14, 2024
26 of 28 checks passed
@sbc100 sbc100 deleted the overloadTable branch October 14, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants