Suppress new Clang warnings on memcpy of nontrivially-copyable objects #22798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Oct 29, 2024
Co-authored-by: Alon Zakai <[email protected]>
sbc100
reviewed
Oct 29, 2024
| def test_poppler(self): | ||
| # See https://github.com/emscripten-core/emscripten/issues/20757 | ||
| self.emcc_args.append('-Wno-deprecated-declarations') | ||
| self.emcc_args.extend(['-Wno-deprecated-declarations', '-Wno-nontrivial-memaccess']) |
Collaborator
There was a problem hiding this comment.
We tend to just use += rather than extend
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 30, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 30, 2024
sbc100
added a commit
that referenced
this pull request
Oct 30, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 30, 2024
sbc100
added a commit
that referenced
this pull request
Oct 30, 2024
dschuff
added a commit
to dschuff/emscripten
that referenced
this pull request
Oct 30, 2024
Another followup to emscripten-core#22798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#111434