Skip to content

Suppress new Clang warnings on memcpy of nontrivially-copyable objects #22798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Suppress new Clang warnings on memcpy of nontrivially-copyable objects #22798

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11cd3a9
Suppress new Clang warnings about memcpy of nontrivially-copyable obj…
dschuff Oct 29, 2024
026d636
add changelog
dschuff Oct 29, 2024
56baa23
Update ChangeLog.md
dschuff Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ See docs/process.md for more on how version tagging works.

3.1.71 (in development)
-----------------------
- The `-Wnontrivial-memaccess` warning has been updated to also warn about
passing non-trivially-copyable destrination parameter to `memcpy`,
`memset` and similar functions for which it is a documented undefined
behavior (#22798). See https://github.com/llvm/llvm-project/pull/111434

3.1.70 - 10/25/24
-----------------
Expand Down
3 changes: 2 additions & 1 deletion test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6795,6 +6795,7 @@ def test_bullet(self, use_cmake):
'-Wno-format',
'-Wno-bitfield-constant-conversion',
'-Wno-int-to-void-pointer-cast',
'-Wno-nontrivial-memaccess',
]

# extra testing for ASSERTIONS == 2
Expand All @@ -6818,7 +6819,7 @@ def test_bullet(self, use_cmake):
@is_slow_test
def test_poppler(self):
# See https://github.com/emscripten-core/emscripten/issues/20757
self.emcc_args.append('-Wno-deprecated-declarations')
self.emcc_args.extend(['-Wno-deprecated-declarations', '-Wno-nontrivial-memaccess'])
Copy link
Collaborator

@sbc100 sbc100 Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to just use += rather than extend

poppler = self.get_poppler_library()
shutil.copy(test_file('poppler/paper.pdf'), '.')

Expand Down
Loading