Skip to content

Use preset to set doesNotExistError instead of postset. NFC #23026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use preset to set doesNotExistError instead of postset. NFC #23026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/library_memfs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
addToLibrary({
$MEMFS__deps: ['$FS', '$mmapAlloc'],
#if !ASSERTIONS
$MEMFS__postset: `
Copy link
Collaborator

@sbc100 sbc100 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how MEMFS.doesNotExistError could get used before the postset run? IIUC the post set code is emitted at the top level at the end of the library top level code. Is the problem that other postset code wants to run first?

Wouldn't preset attempt to set MEMFS.doesNotExistError before MEMFS itself is created?

Copy link
Collaborator

@sbc100 sbc100 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually __preset just doesn't exist. Only __postset. So I'm not sure how this could work.

$MEMFS__preset: `
// This error may happen quite a bit. To avoid overhead we reuse it (and
// suffer a lack of stack info).
MEMFS.doesNotExistError = new FS.ErrnoError({{{ cDefs.ENOENT }}});
Expand Down